Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fbx] Port FBX module from 3.2 branch #44499

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[fbx] Port FBX module from 3.2 branch #44499

merged 1 commit into from
Dec 23, 2020

Conversation

RevoluPowered
Copy link
Contributor

@RevoluPowered RevoluPowered commented Dec 18, 2020 •
edited

Does what it says in the tin. Work in progress

Porting to 4.0 was delayed on purpose so we could land the many FBX fixes in the 3.2 branch so that further QC went on.

Supersedes #41985

Commit includes SHA so we know what branch has what version of the FBX module.

@RevoluPowered RevoluPowered changed the title Port FBX module from commit 68013d23932688e57b489600f4517dd280edc464 [fbx] Port FBX module from commit 68013d23932688e57b489600f4517dd280edc464 Dec 18, 2020
@RevoluPowered RevoluPowered changed the title [fbx] Port FBX module from commit 68013d23932688e57b489600f4517dd280edc464 [fbx, wip] Port FBX module from commit 68013d23932688e57b489600f4517dd280edc464 Dec 18, 2020
@RevoluPowered RevoluPowered added this to the 4.0 milestone Dec 18, 2020
@RevoluPowered RevoluPowered changed the title [fbx, wip] Port FBX module from commit 68013d23932688e57b489600f4517dd280edc464 [fbx, wip] Port FBX module from 3.2 branch Dec 18, 2020
@RevoluPowered RevoluPowered mentioned this pull request Dec 18, 2020
Closed
@RevoluPowered RevoluPowered mentioned this pull request Dec 21, 2020
Closed
@RevoluPowered
Copy link
Contributor Author

RevoluPowered commented Dec 22, 2020 •
edited

I took the opportunity to rewrite the FBX material handling like I promised for 4.0.

We are right now looking for a sensible default for our transparency properties. #44579

I'll re-add the standard properties tomorrow and for 'transparency' most likely will just set alpha, unless we can make the same guarantee's as it had when it was exported from Blender, Maya or Max, which currently isn't happening.

For emission, and various other things I can add that back in tomorrow it's fairly simple to do.

Standard Texture Mappings all work as they did before already so loading scenes should be correct now, except their feature/properties.

@RevoluPowered
Copy link
Contributor Author

Legacy non PBR assets will be dealt with in later PR we are discussing some legacy components on a lot of assets, hang tight on replies someone is gonna write up some additional notes on our findings.

godotengine/godot-proposals#2010

@RevoluPowered RevoluPowered force-pushed the fbx_plugin_port_4.0 branch 2 times, most recently from 28df8cf to eeea939 Compare December 22, 2020 21:23
@RevoluPowered RevoluPowered changed the title [fbx, wip] Port FBX module from 3.2 branch [fbx] Port FBX module from 3.2 branch Dec 22, 2020
@RevoluPowered RevoluPowered mentioned this pull request Dec 22, 2020
Merged
@RevoluPowered RevoluPowered force-pushed the fbx_plugin_port_4.0 branch 3 times, most recently from 1335592 to 311664c Compare December 22, 2020 22:53
akien-mga
akien-mga reviewed Dec 22, 2020
View reviewed changes
modules/fbx/readme.md Outdated Show resolved Hide resolved
@RevoluPowered
Port FBX module from commit 68013d2
6607fc7 
Ports FBX module from 3.2 branch to 4.0

This is the only time the plugin will be updated from 3.2 and marks the final time we do this, from now on we will backport FBX to 3.2 with fixes.

Changelog:
- fixed crash importing files with buggy format (because of bad newlines in ASCII data, this is yet to be fixed fully)
- fixed const correctness with C++/C version change
- rewrote material handling to be simpler and better
- ports from 3.2 to 4.0 the fbx importer
@akien-mga akien-mga merged commit 35a8eba into godotengine:master Dec 23, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:import
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RevoluPowered @akien-mga