Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unselect to deselect #44569

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

madmiraal
Copy link
Contributor

As originally identified in #28558, "unselect" should be "deselect".

This PR:

  • Renames ItemList's methods unselect() and unselect_all to deselect() and deselect_all()
  • Renames GraphEdit's signal node_unselected() to node_deselected()

and for consistency and to make it clear that it deselects all items:

  • Renames FileDialog's deselect_items() to deselect_all()

Part of #16863

@akien-mga akien-mga merged commit feb4e5e into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-unselect-deselect branch December 29, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants