-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port HTTPRequest gzip compression to 3.4 #48651
Conversation
@Wavesonics I hope I ported your code faithfully, thank you for the original PR! |
Nice, it looks good to me! |
Fix doc issues Use memcpy Bind RESULT_BODY_DECOMPRESS_FAILED Docs update
@Calinou sorry to ping you on this, is there something else I should do to push for this in the 3.4 release? Excited to see this feature speeding up my API calls :) |
Thanks! |
This causes a few regressions including #53085 so it needs to be reverted. The original PR on master #38944 is left for now but will need work if we want to keep in 4.0 (or will need revert too). Issues:
|
I can put some time in on the master implementation to get it fixed up |
Will this feature be looked into again? |
@RPicster if we have a working master implementation then this should be pretty trivial to port back to 3.x again. |
I'm taking a look at what needs to be done here,
Other than these 3 issues is there anything else that is needed to consider this fixed? |
#55946 addresses the 2nd two points listed above, we can now stream decompress a file to another file (though that is not exposed through GDScript yet.) and that is then used to decompress the downloaded to file option in I don't have any idea how we deal with HTML5 as a platform in Godot, so maybe someone could clue me in. It sort of sounds like on HTML5 exports, we should just turn off the "Accept Gzip header" option under the hood or something? |
Tests are finally passing 🎉
#48581
Edit: Backport of #38944