[3.x] Optimize raycast with large Heightmap shape data #48709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
force-pushed
the
heightmap-raycast-acceleration-3.x
branch
2 times, most recently
from
c3ce208
to
b9a0e00
Compare
reduz
approved these changes
Sep 4, 2021
Zylann
reviewed
Sep 4, 2021
There was a problem hiding this comment.
Been a while since I wrote this in Bullet, but it looks ok. Did not test because I dont have master setup.
I only left a few comments about minor improvements.
Also, considering this algorithm traverses a heightmap that will never exceed the largest sizes an image can have, I'm not sure if using real_t for double is necessary, but it's probably good enough
Port raycast accelerator from Bullet's btHeightfieldTerrainShape.
pouleyKetchoupp
force-pushed
the
heightmap-raycast-acceleration-3.x
branch
from
b9a0e00
to
bb6760a
Compare
|
@Zylann Thanks for the review! I've just rebased and made the changes you suggested. I'm merging since you said you approved on the chat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port raycast accelerator from Bullet's btHeightfieldTerrainShape (originally made by @Zylann).
Allows raycasting on heightmap shapes to have about the same performance in Godot Physics as in Bullet.
3.x backport of PR #48708