Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Improve the generated ZIP archive name when using Download Project Source #49597

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 14, 2021

3.x version of #49598.

This makes for easier organization since downloading a project several times (or several different projects) will result in more meaningful file names.

I haven't been able to test this (not even with a HTTPS-enabled local web server), so someone else will have to test it before this can be merged.

@Calinou Calinou requested a review from a team as a code owner June 14, 2021 13:05
@Calinou Calinou changed the title Improve the generated ZIP archive name when using Download Project Source Improve the generated ZIP archive name when using Download Project Source (3.x) Jun 14, 2021
@Calinou Calinou added this to the 3.4 milestone Jun 14, 2021
@Calinou Calinou force-pushed the web-editor-improve-download-project-source-zip-name-3.x branch 2 times, most recently from 02b3d7b to 093fa83 Compare August 16, 2021 16:33
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
@akien-mga
Copy link
Member

This went under the radar, but the master PR was merged so it could likely be too. Probably needs a rebase / resync with the master PR, including a fix for a regression that it caused: #49598 (comment)

…urce

This makes for easier organization since downloading a project several
times (or several different projects) will result in more meaningful
file names.
@Calinou Calinou force-pushed the web-editor-improve-download-project-source-zip-name-3.x branch from 093fa83 to 1d71d84 Compare June 27, 2023 11:05
@Calinou
Copy link
Member Author

Calinou commented Jun 27, 2023

This went under the radar, but the master PR was merged so it could likely be too. Probably needs a rebase / resync with the master PR, including a fix for a regression that it caused: #49598 (comment)

Done. I haven't been able to test this locally as I can't get the web editor to run in either Firefox or Chromium with platform/javascript/serve.py (indirect call to null error).

@Calinou Calinou changed the title Improve the generated ZIP archive name when using Download Project Source (3.x) [3.x] Improve the generated ZIP archive name when using Download Project Source Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants