Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Improve and streamline VisualScriptFuncNodes Call Set Get #50709

Conversation

Gallilus
Copy link
Contributor

This PR improves and streamlines the workflow for VisualScriptFunctionNodes Call Set Get
Uniform design.
Drag in set-get from tree is now working.

3.x version of #49749
image
Controlsgc.zip

Compatibility whit older scripts is NOT guaranteed as I added the pass output port for get instance.
I do want to note that the other changes is are a real big improvement to the UX

@Gallilus Gallilus requested a review from a team as a code owner July 21, 2021 18:45
@Gallilus Gallilus changed the title Improve and streamline VisualScriptFuncNodes Call Set Get [3.x] Improve and streamline VisualScriptFuncNodes Call Set Get Jul 21, 2021
@Calinou Calinou added this to the 3.4 milestone Jul 22, 2021
@akien-mga
Copy link
Member

Compatibility whit older scripts is NOT guaranteed as I added the pass output port for get instance.

We need to make sure that scripts created in Godot 3.3 can still be opened in Godot 3.4, otherwise users would lose work (it's a binary format so if it's incompatible, it will just been seen as corrupt and they won't be able to open it).

@Gallilus
Copy link
Contributor Author

I don't think the binary wil complain, think the logic wil use pass_object opose to the value.
This evening I wil do some test.
Worst case scenario we leave pass out of it.

@Gallilus
Copy link
Contributor Author

Tested
New project in version 3.3.2
image

Opened in version 0ab6495
image

Working as you would expect. And In the past there where now issues with opening scripts between builds.

@akien-mga
Copy link
Member

I'm not familiar with the pass concept but in that second screenshot, shouldn't the print node get its value from position instead of pass?

This PR improves and streamlines the workflow for VisualScriptFunctionNodes Call Set Get
Uniform design.
Drag in set-get from tree is now working.
port 'pass' not backported to 3.x to keep script backwards compatibility
@Gallilus
Copy link
Contributor Author

Exactly that is the compatibility error.
So I am already reverting this pass change the push wil be tomorrow.
Goodnight.

@Gallilus Gallilus force-pushed the Improve-and-stramline-VisualScriptFuncNodes-Call-Set-Get branch from 0ab6495 to af1ea18 Compare July 23, 2021 09:24
@Gallilus
Copy link
Contributor Author

Now its backwards compatible.
Left a few "// port 'pass' not backported to 3.x to keep script backwards compatibility" in there so the next person wil not wast time.

image

@akien-mga akien-mga merged commit 48d80b3 into godotengine:3.x Jul 23, 2021
@akien-mga
Copy link
Member

Thanks!

@Gallilus Gallilus deleted the Improve-and-stramline-VisualScriptFuncNodes-Call-Set-Get branch July 24, 2021 10:37
Gallilus added a commit to Gallilus/godot that referenced this pull request Aug 20, 2021
Revert a part of godotengine#50709.
Adding a sequence port to basic type set breaks backwards compatibility
sairam4123 pushed a commit to sairam4123/godot that referenced this pull request Nov 10, 2021
Revert a part of godotengine#50709.
Adding a sequence port to basic type set breaks backwards compatibility
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this pull request Dec 18, 2021
Revert a part of godotengine#50709.
Adding a sequence port to basic type set breaks backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants