Fix Xbox controllers in Bluetooth mode on macOS (3.x) #51117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apertureless You can test this pull request by downloading one of the GitHub Actions builds for the macOS editor (once the build is finished). Note that it isn't codesigned, so you may have to perform the usual steps to run unsigned applications on macOS. |
Calinou
changed the title
|
Yep this seems to fix the issue (for me). |
|
FWIW this fixes the issue for me as well. |
akien-mga
reviewed
Aug 16, 2021
This prevents the D-pad up arrow from being registered as pressed when it isn't, and pressing any direction from activating the next arrow clockwise of it. Co-authored-by: Scott Wadden <scott.wadden@gmail.com>
Calinou
force-pushed
the
macos-fix-xbox-bluetooth-controllers-3.x
branch
from
4b2223a
to
f95035b
Compare
akien-mga
approved these changes
Aug 16, 2021
|
Thanks! |
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #51116.This prevents the D-pad up arrow from being registered as pressed when it isn't, and pressing any direction from activating the next arrow clockwise of it.
Thanks @dsrw for providing this fix 🙂