OS::is_process_running function. #51682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdavisprog
force-pushed
the
os-is-process-running
branch
from
84383c8
to
ccc76c2
Compare
|
Came looking for this, this is very much needed for a project I'm working on, any chance of this being merged? |
akien-mga
reviewed
May 3, 2022
akien-mga
reviewed
May 3, 2022
akien-mga
added
the
cherrypick:3.x
Adds the is_process_running function to the native OS class and exposes it to script. This is implemented on Windows and Unix platforms. A stub is provided for other platforms that do not support this function. Documentation is updated to reflect new API function.
mdavisprog
force-pushed
the
os-is-process-running
branch
from
ccc76c2
to
f3c1232
Compare
akien-mga
approved these changes
May 4, 2022
|
Hello, I have implemented the feedback and the branch is now rebased with the latest from master. If there is anything else that needs attention, let me know. |
|
Thanks! |
|
thanks |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the OS::is_process_running function that is exposed to script. The function has been implemented for Windows and Unix platforms and provides stubs for other platforms that are unsupported.
This is relevant to the godot-proposal #1679.
A test project is provided that creates a process to run the 'ping' command and asserts that the is_process_running function properly returns the correct value.
os-is-process-running-project.zip
Bugsquad edit: This closes godotengine/godot-proposals#1679.