Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks/fixes for the Command Palette #51703

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Aug 15, 2021

Had the wish for these changes to be made, but didn't want to keep bothering the student. So I just waited so I could do them myself.

  • Fix first section being hidden by being scrolled up on popup.
  • Made sections non-selectable. This prevents the dialog from trying to open a command with it, resulting in an error message.
  • Took the time to also disable selecting the sections in the shortcut tab in the Editor Settings as well.
  • Removed the "No matches found" when no commands are found given the search string. It implementation felt hacky, and I honestly don't feel it was really needed.
  • General code tidy up.

@YeldhamDev YeldhamDev added this to the 4.0 milestone Aug 15, 2021
@YeldhamDev YeldhamDev requested a review from a team August 15, 2021 22:52
@akien-mga
Copy link
Member

CC @Bhu1-V

Copy link
Contributor

@EricEzaM EricEzaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

editor/editor_command_palette.cpp Show resolved Hide resolved
@akien-mga akien-mga merged commit 5ccf797 into godotengine:master Aug 19, 2021
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the compal_tweaks branch August 19, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants