Fix renaming directories #51793
Merged
Fix renaming directories #51793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
bug
topic:core
topic:gdscript
regression
cherrypick:3.x
akien-mga
reviewed
Aug 17, 2021
|
Maybe also update the doc which currently only mentions files. |
akien-mga
approved these changes
Aug 17, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
toasterofbread
added a commit
to toasterofbread/godot
that referenced
this pull request
Aug 26, 2021
Ported PR godotengine#51793 to 3.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48254
Seems like
dir_exists()is less strict with names, e.g. "" or ".." are valid directories even though it will result in the same bug as #41623, so I added some basic checks for invalid paths.