[3.x] [Net] ENet poll optimizations, fragmented unreliable transfer. #53130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to always send them reliably when transfer mode was unreliable or ordered if the packet size was more then the enet host MTU (1400 bytes by default). This commit also adds a warning when debug is enabled to explain the effects of sending fragmented packets unreliably.
It used to call `enet_host_service` until all events were consumed, but that also meant constantly polling the connection leading to potentially unbounded processing time. It now only service the connection once, and instead consumes all the retrieved events via `enet_host_check_events`.
Faless
changed the title
|
I'd really like to see all of #51466 merged. We're depending on some of the efficiencies in sendMsg. |
|
Didn't have a chance to test yet, unfortunately. |
|
Does this need an update to match what got merged in #53129? |
|
@akien-mga no, this is up to date, and good to merge to |
akien-mga
approved these changes
Dec 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
2 out of the 3 changes in #51466 (+ debug warning when sending unreliable fragmented packets).
The other change (
sendmsg/WSASendTo) needs more testing because according to MS docsWSABUFis not available in UWP apps (though WSASendTo is?)Bugsquad edit:
3.xversion of #53129.