Add length and length_squared to Vector2i/3i #53618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to add tests to validate that the methods work properly. |
aaronfranke
force-pushed
the
signed-angle-vec3i
branch
from
74c351e
to
0ca9024
Compare
raulsntos
reviewed
Nov 29, 2021
aaronfranke
force-pushed
the
signed-angle-vec3i
branch
from
61c1a77
to
e449ce2
Compare
aaronfranke
force-pushed
the
signed-angle-vec3i
branch
from
e449ce2
to
653679b
Compare
akien-mga
reviewed
Jan 6, 2022
core/math/vector3i.h
Outdated
Comment on lines
135
to
141
| double Vector3i::length() const { | ||
| int64_t x2 = x * int64_t(x); | ||
| int64_t y2 = y * int64_t(y); | ||
| int64_t z2 = z * int64_t(z); | ||
|
|
||
| return Math::sqrt(double(x2 + y2 + z2)); | ||
| } |
There was a problem hiding this comment.
Could be sqrt of length_squared() I guess unless we're really concerned that it wouldn't be inlined?
There was a problem hiding this comment.
It was done this way to be consistent with how it's currently done in Vector3, but I agree that it's simpler to just take the sqrt of length_squared(), so updated. I left Vector3 alone.
|
PR meeting: We decided to only implement |
aaronfranke
force-pushed
the
signed-angle-vec3i
branch
from
653679b
to
2c52f16
Compare
aaronfranke
changed the title
akien-mga
approved these changes
Jan 7, 2022
|
Thanks! |
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See godotengine/godot-proposals#2297 (does not close it).