-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Add a setting to reduce dark SSAO artifacts when the camera gets close to materials #53785
base: 3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think users should be able to set their AO to black if they want.
We should solve the bug that causes SSAO to become unnecessarily dark when the camera approaches a surface instead.
If you are only interested in a stopgap solution, then a configurable max should be exposed like in 4.0:
obscurance = min(obscurance, params.shadow_clamp); |
note: in the attached code, we are dealing with obscurance so a
min
function is used
I added a setting for this. It requires increasing the number of binder arguments from 13 to 14, which means the diff is large compared to the feature itself. |
7310210
to
3e5795b
Compare
3e5795b
to
d7998e2
Compare
71cb8d3
to
c58391c
Compare
…e to materials This setting clamps final SSAO intensity. With this setting correctly configured, SSAO artifacts will still occur, but they'll be much less noticeable.
d7998e2
to
33f3c12
Compare
Follow-up to #53784.
This setting clamps final SSAO intensity. With this setting correctly configured, SSAO artifacts will still occur, but they'll be much less noticeable.
The default value is 1.0, which means the existing behavior is unchanged.
This closes godotengine/godot-proposals#3720.
Testing project: test_ssao_3_3.x.zip
Preview
ssao-max-obscurance-setting.mp4
Scene 1
Scene 2