Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format: Sync config with LLVM 13 #54133

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

akien-mga
Copy link
Member

Disable minimum amount of spaces in comment prefix for now, as it otherwise
modifies the whole codebase. That's something we probably want to use as it
matches our convention, but we should look into fully converting these
comments to our style guide at the same time.

@akien-mga akien-mga added this to the 4.0 milestone Oct 22, 2021
@akien-mga akien-mga requested a review from a team as a code owner October 22, 2021 18:42
@akien-mga
Copy link
Member Author

For the record, all the commented out entries are the ones from clang-format --style LLVM --dump-config.

https://clang.llvm.org/docs/ClangFormatStyleOptions.html now shows the version in which specific options have been added, so it can be used to review recently added options from clang-format 11, 12 or 13. (Some are marked 14 and yet available in 13 for me, FYI.)

Disable minimum amount of spaces in comment prefix for now, as it otherwise
modifies the whole codebase. That's something we probably want to use as it
matches our convention, but we should look into fully converting these
comments to our style guide at the same time.
@akien-mga akien-mga merged commit 92cab5f into godotengine:master Oct 22, 2021
@akien-mga akien-mga deleted the clang-format-13-sync branch October 22, 2021 20:43
@akien-mga
Copy link
Member Author

Cherry-picked for 3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant