Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle test body motion with 0 margin #55762

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Margin needs to have a high enough value for test body motion to work properly (separate using the margin, move without then gather rest info with the margin again).

Fixes issues with test motion returning no collision in some cases with margin equal to 0.
Fixes #16414

Margin needs to have a high enough value for test body motion to work
properly (separate using the margin, move without then gather rest info
with the margin again).

Fixes issues with test motion returning no collision in some cases with
margin equal to 0.
@pouleyKetchoupp pouleyKetchoupp added bug topic:physics cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:2d topic:3d labels Dec 9, 2021
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Dec 9, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team December 9, 2021 17:56
@akien-mga akien-mga merged commit 7e720b4 into godotengine:master Dec 10, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 10, 2021
@pouleyKetchoupp pouleyKetchoupp deleted the body-motion-no-margin branch December 10, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RigidBody2D#test_motion behaving weird
2 participants