Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix mouse speed not changing fast enough #56765

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

madmiraal
Copy link
Contributor

3.x version of #56764.

- Uses all accumulated movements when calculating speed
- Discards old accumulated movements
- Sets last mouse speed to zero when there is no movement
@madmiraal madmiraal requested review from a team as code owners January 13, 2022 20:19
@Calinou Calinou added this to the 3.5 milestone Jan 13, 2022
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We merged the master PR and I don't recall regression reports, so this could be considered to merge for 3.6 (and possibly cherry-pick).

@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jul 3, 2022
@akien-mga akien-mga merged commit daa5b54 into godotengine:3.x Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 5, 2022
@madmiraal madmiraal deleted the fix-45592-2-3.x branch August 6, 2022 07:06
@akien-mga
Copy link
Member

I'd err on the side of caution here and leave this out for 3.5.x. We'd likely want significant user testing of 3.6 betas before we can call this "safe" for 3.5.x and by that time 3.6 will be close to release ready and 3.5.x already well stabilized.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants