Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for SubViewportContainer input handling #57687

Closed
wants to merge 5 commits into from
Closed

Proposal for SubViewportContainer input handling #57687

wants to merge 5 commits into from

Commits on Feb 7, 2022

  1. Change subviewport input to gui-input 

    Handle propagation of gui-event to unhandled-input-event inside viewport
This also fixes TouchScreenButton events never get treated as unhandled_input_events

These changes make SubViewportContainer::unhandled_input obsolete
    @Sauermann
    Sauermann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4326658 View commit details
    Browse the repository at this point in the history

  2. Do not release focus in other viewports of the current window, but ju… 

    …st in the current viewport

This allows proper event propagation through Viewport-transitions
    @Sauermann
    Sauermann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    cf2d5ab View commit details
    Browse the repository at this point in the history

  3. Fix coordinate transposition to also work with sub-sub-viewports

    @Sauermann
    Sauermann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    086ee7e View commit details
    Browse the repository at this point in the history

  4. Physics picking should indicate input as handled 

    This is necessary, because there might be cases where
outside of the current SubViewport Events could be triggered afterwards
Also keep physics mouseover after physics picking
    @Sauermann
    Sauermann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f08c3d6 View commit details
    Browse the repository at this point in the history

  5. Connect notifications from Container to Viewport 

    Handle mouse enter+exit and focus exit
    @Sauermann
    Sauermann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    2a422fd View commit details
    Browse the repository at this point in the history