Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port existing _notification code to use switch statements instead of if - Batch B #58169

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Port existing _notification code to use switch statements instead of if - Batch B #58169

merged 1 commit into from
Feb 16, 2022

Conversation

megalobyte
Copy link
Contributor

Implements batch B of #58155

@megalobyte megalobyte requested review from a team as code owners February 16, 2022 03:07
@Chaosus Chaosus added this to the 4.0 milestone Feb 16, 2022
akien-mga
akien-mga approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs adding separation lines in:

} break;

case NEW_CASE: {

@megalobyte megalobyte force-pushed the update-notificatin-if-to-switch-batch-B branch from a58e578 to 8824b6c Compare February 16, 2022 13:44
@megalobyte megalobyte requested a review from a team as a code owner February 16, 2022 13:44
@akien-mga akien-mga merged commit 33c7f52 into godotengine:master Feb 16, 2022
@akien-mga
Copy link
Member

Thanks!

@megalobyte megalobyte deleted the update-notificatin-if-to-switch-batch-B branch February 16, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megalobyte @akien-mga @Chaosus