Rework scene creation dialog

[KoBeWi]

Replaces this thing

With this 😎

Closes #34524

[fire-forge]

I think it could use a bit of padding here, maybe 4px:

Also instead of always using the regular Node icon for custom type, it could change to the icon of whatever node is selected.

Aside from that, the new design is pretty good!

[Ansraer]

Hmm, the indentation of the radio buttons feels wrong to me when compared to scene name and root name fields. Maybe some padding between the last radio option and scene name could help?
Or maybe try moving the radio buttons below the root name field. Having the top fields look less indented than the bottom ones will probably look better.

Also, I think you should remove the dot in the root name placeholder text. Most UIs I can think of don't use punctuation in input hints.

[KoBeWi]

Ok seems finished:

godot.windows.tools.64_GYo2MVWjXR.mp4

Doing code cleanup rn.

[fire-forge]

What do you think about using a dropdown list/OptionButton for the scene file extension? I noticed it only allows .tscn and .scn and not any arbitrary extensions, so that would make it easier to know what extensions are allowed and would remove the need for the invalid extension warning message.

[Ansraer]

I really think this would look better if you moved scene name and root name above root type.

[KoBeWi]

What do you think about using a dropdown list/OptionButton for the scene file extension?

Done:

I really think this would look better if you moved scene name and root name above root type.

Not really:

[akien-mga]

Thanks!

[Sslaxx]

Any chance of this being cherrypicked?

[djrain]

Very nice improvement. Overall it feels a bit cramped though, could there be a bit more separation between categories? And on the other hand, the vertical spacing between the radio options seems maybe a bit much, though we do want them to be easily clickable so maybe not... but the spacing between error text lines could be condensed.

IMO it would be better if the "root type" showed the actual node names. Node2D / Control etc. would be more immediately recognizable to any non-beginner. Also the cancel/confirm buttons should be swapped.

[fire-forge]

IMO it would be better if the "root type" showed the actual node names. Node2D / Control etc. would be more immediately recognizable to any non-beginner.

I personally think the buttons are fine the way they are now. It describes the intent of the scene (2D, 3D, or UI) instead of the actual node type used.

Also the cancel/confirm buttons should be swapped.

The cancel and ok buttons order is different depending on the platform. So whichever platform you're on must use a different order than the platform KoBeWi took the screenshots on. See this quote from #59382:

The position (left/right) of the Cancel and OK buttons in AcceptDialog
are DisplayServer specific, as Windows uses OK/Cancel and macOS uses Cancel/OK.