Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Enable exporting nodes to the inspector #62789

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

raulsntos
Copy link
Member

Follow-up to #62185 that implements godotengine/godot-proposals#1048 for C#.

We may want to wait for the dotnet6 branch to be merged first, in which case I can remake this PR.
For the dotnet6 branch, the implementation would have to be moved to:

if (variantType == VariantType.Object && type is INamedTypeSymbol memberNamedType &&
memberNamedType.InheritsFrom("GodotSharp", "Godot.Resource"))
{
string nativeTypeName = memberNamedType.GetGodotScriptNativeClassName()!;
hint = PropertyHint.ResourceType;
hintString = nativeTypeName;
return true;
}

@raulsntos raulsntos added this to the 4.0 milestone Jul 6, 2022
@raulsntos raulsntos requested a review from a team as a code owner July 6, 2022 19:30
Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to merge it before dotnet6. This one will be easy to rewrite while rebasing.

@akien-mga akien-mga merged commit 3768236 into godotengine:master Jul 7, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants