Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpriteFrames: Sort animations alphabetically #62978

Merged

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jul 13, 2022

And finally remove the 'frames' property which was added for compatibility with 2.1
in bed3efb.
Fixes #21765, got to redo #21780 without even remembering it :)

The 'animations' property on the other hand is needed, contrarily to what its comment
said (copy-paste mistake probably).

Also removes unused '_get_animation_list' (as done in #49495).

master version of #62977.

And finally remove the 'frames' property which was added for compatibility with 2.1
in bed3efb.
Fixes godotengine#21765.

The 'animations' property on the other hand is needed, contrarily to what its comment
said (copy-paste mistake probably).

Also removes unused '_get_animation_list'.
@akien-mga akien-mga force-pushed the spriteframes-sort-anims-alphabetically branch from 3a64e5c to 4639050 Compare July 13, 2022 14:15
@akien-mga akien-mga requested a review from a team as a code owner July 13, 2022 14:15
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #62977 (review).

@akien-mga akien-mga merged commit 98d5b37 into godotengine:master Jul 13, 2022
@akien-mga akien-mga deleted the spriteframes-sort-anims-alphabetically branch July 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpriteFrames::_get_frames() just return a new empty Array
2 participants