Added allow_echo parameter to accept echo events for popup menu item shortcut

[deakcor]

In popup menu, item shortcut currently only accepts first pressed event which is ok for most of the cases but accepting echo events can be useful for undo/redo items for example :

So added optional parameter allow_echo on functions which add a shortcut to items.

Here a code to reproduce the behavior (you just need to add a MenuButton to your scene):

func _ready():
	var popup:PopupMenu = $MenuButton.get_popup()
	popup.add_item("Undo",0)
	var shortcut:Shortcut = Shortcut.new()
	var event:InputEventKey = InputEventKey.new()
	event.ctrl_pressed = true
	event.keycode = KEY_Z
	shortcut.events.push_back(event)
	popup.set_item_shortcut(0,shortcut,true,true) #here last parameter is allow_echo
	popup.id_pressed.connect(test_print)

func test_print(_id):
	print("undo")

[KoBeWi]

Related to #36493

[deakcor]

Related to #36493

Yes missed this one. Yours seems better, less changes and it should work with accelerator too

[KoBeWi]

I compared our implementations. Yours seems more complete (with ITEM_SETUP_WITH_SHORTCUT, although not sure if useful), but it also adds redundant argument to activate_item_by_event(). Other than that they are more or less the same.

[akien-mga]

Superseded by #36493. Thanks for the contribution!