Fix Tree buttons sometimes displaying incorrect tooltips #64771
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase. |
Mickeon
force-pushed
the
fix-tree-button-tooltip
branch
from
7ab7a90
to
b46eccd
Compare
|
Rebased. |
Mickeon
force-pushed
the
fix-tree-button-tooltip
branch
from
b46eccd
to
dfa9103
Compare
KoBeWi
reviewed
Dec 22, 2022
Comment on lines
5053
to
5055
| if (h_scroll->is_visible_in_tree()) { | ||
| pos.x += h_scroll->get_value(); | ||
| //pos.x += h_scroll->get_value(); | ||
| } |
There was a problem hiding this comment.
This should be removed if does nothing.
KoBeWi
reviewed
Dec 22, 2022
| @@ -5062,25 +5062,24 @@ String Tree::get_tooltip(const Point2 &p_pos) const { | |||
|
|
|||
| if (it) { | |||
| const TreeItem::Cell &c = it->cells[col]; | |||
| int col_width = get_column_width(col); | |||
| int col_width = get_size().width - theme_cache.panel_style->get_minimum_size().width - (h_scroll->is_visible_in_tree() ? h_scroll->get_minimum_size().width : 0); | |||
There was a problem hiding this comment.
You could change it into conditional code like the one above, for better clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making #64733 , I noticed an oddity
This happens because Tree's... TreeItem's... Cells... Buttons remain in the same position, regardless of h_scroll, but this has not been accounted for appropriately when fetching the tooltip, resulting in the tooltip only being displayed correctly if the horizontal scroll was all the way to the right.
This has been adjusted, but may require some extra testing because I do not understand the behaviour of Tree buttons & scrolling, should there be more than one column.
