New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename range_lerp
to remap
#65361
Rename range_lerp
to remap
#65361
Conversation
d04bd36
to
9b15043
Compare
9b15043
to
69479c6
Compare
I don't understand the Linux Error anymore:
It's no property, it's a global scope function...! And it does exist in this PR! |
The errors point directly to the code you should inspect. 😉 godot/editor/project_converter_3_to_4.cpp Lines 2600 to 2602 in 69479c6
(so to get rid of the errors you'd need to add lerp_range to that array).
|
Thank you! |
424baa3
to
876c58d
Compare
876c58d
to
d721319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've left LerpRange
in C#.
d721319
to
b6daad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in PR review meeting.
Thanks! |
Closes godotengine/godot-proposals#5335 (?).
This PR was renaming it to lerp_rangeShould the favour go toremap()
this PR can easily be changed to match (or closed outright if rejected).