GLTF imports & exports material texture filters #66856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaticInAHat
force-pushed
the
gltf_texture_filter_fix_3
branch
from
5b59cba
to
bb34c55
Compare
fire
approved these changes
Oct 4, 2022
|
It works on the Windows build.
|
|
Thanks! |
|
I have unfortunately just found an asset that this code does not work properly for. I will be opening a PR with a fix shortly, once I've convinced myself that I've finally got things right. My apologies for not discovering this sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports improvements to the GLTF import code from PR #59481 into the 3.x branch. Specifically, the importer is updated such that imported materials have the correct texture filter modes set (with respect to the sampling specified in the imported file).
Note that the logic and implementation of this PR aren't exactly the same as in the 4.x branch, due to some shifts in responsibility for filtering between the Texture and Material classes, however it targets the same behavior, and has the same general structure.