[MP] Move packet relay and peer signaling code to SceneMultiplayer. #67094
Conversation
Faless
force-pushed
the
mp/4.x_server_relay_unify
branch
from
598b6d3
to
aa05345
Compare
|
Converted to draft since it doesn't currently respect channel and trasfer mode when relaying. |
Faless
force-pushed
the
mp/4.x_server_relay_unify
branch
from
283dbdc
to
8cf2c31
Compare
Fixed now, and ready for review. |
Faless
force-pushed
the
mp/4.x_server_relay_unify
branch
from
8cf2c31
to
bacc9a7
Compare
|
Rebased after #66594 |
There was a problem hiding this comment.
This looks great! I particularly like the WebRTC changes: the new method of doing "server compatibility" is easier to understand both internally and externally, and now that messages can be relayed through the server, it's really actually compatible.
Reading through the code, I only found little nitpicky things. I tested with ENet, but I haven't done a proper test with WebRTC or WebSockets yet.
Faless
force-pushed
the
mp/4.x_server_relay_unify
branch
from
bacc9a7
to
4609593
Compare
MultiplayerPeer changes: - Adds is_server_relay_supported virtual method Informs the upper MultiplayerAPI layer if it can signal peers connected to the server to other clients, and perform packet relaying among them. - Adds get_packet_channel and get_packet_mode virtual methods Allows the MultiplayerAPI to retrieve the channel and transfer modes to use when relaying the last received packet. SceneMultiplayerPeer changes: - Implement peer signaling and packet relaying when the MultiplayerPeer advertise they are supported. ENet, WebRTC, WebSocket changes: - Removed custom code for relaying from WebSocket and ENet, and let it be handled by the upper layer. - Update WebRTC to split create_client, create_server, and create_mesh, with the latter behaving like the old initialize with "server_compatibility = false", and the first two supporting the upper layer relaying protocol.
Faless
force-pushed
the
mp/4.x_server_relay_unify
branch
from
4609593
to
7536d15
Compare
Fixes godotengine/godot-proposals#3208 .
In this PR:
MultiplayerPeercan now report if server relaying is allowed.If this method returns true, the upper
MultiplayerAPIlayer is allowed to signal peers connected to the server to other clients, and perform packet relaying among them.Add support for packet relaying and peer signaling in
SceneMultiplayer.When the
MultiplayerPeersupports relaying packet, the high level multiplayer API will now advertise connected peers, and relay peer packets as requested.Update ENet, WebRTC, WebSocket to support server relay.
Remove custom code for relaying from WebSocket and ENet, and let it be handled by the upper layer.
Update WebRTC to split create_client, create_server, and create_mesh, with the latter behaving like the old initialize with server_compatibility = false, and the first two supporting the upper layer relaying protocol.