Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Improve font glyph cache packing and texture update. #67626

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[3.x] Improve font glyph cache packing and texture update. #67626

merged 1 commit into from
Nov 3, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 19, 2022 •
edited
Loading

Backport of #67562 and #59862 for 3.x.

Test project (modified project from #67520), time are measured with release_debug editor on macOS:
chinese_text_test.zip

Test Time before this PR Time with this pr
Open test project in the editor. 2 min. 20 sec. 4 sec.
Change TextEdit font size to 400. editor crashes instant

@bruvzg
[3.x] Improve font glyph cache packing shelf best height fit heuristi…
46e2e0f 
…c, delay font texture update, until texture is accessed.
@bruvzg bruvzg added this to the 3.x milestone Oct 19, 2022
@bruvzg bruvzg marked this pull request as ready for review October 19, 2022 11:51
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Oct 31, 2022
@akien-mga akien-mga merged commit e0682f6 into godotengine:3.x Nov 3, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the improve_font_packing_and_delay_texture_update_3 branch November 3, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:gui
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bruvzg @akien-mga