-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve clarity of Tree's activated/double-clicked signals #70290
Conversation
Maybe |
@YeldhamDev |
I think if you add it to the project convertor, it would be okay to break compat here. |
b6028f5
to
b420509
Compare
b420509
to
ac54972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, though :) |
Co-authored-by: Yuri Sizov <yuris@humnom.net>
ac54972
to
0e77853
Compare
Thanks! |
When double-clicking a Tree's TreeItem, you might expect
item_double_clicked
to be emitted. However, this signal is badly named. It's only emitted when the icon is double-clicked, not any other part of the item. The actual signal that works when double-clicking on any part of the item isitem_activated
.This PR improves the documentation to make this clear and also renames
item_double_clicked
toitem_icon_double_clicked
to reflect that it only emits when double-clicking on an item's icon.