Fix cursor behavior for multiselect in Tree while holding CTRL #71024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marzecdawid
commented
Jan 7, 2023
| } | ||
|
|
||
| } else { | ||
| if (c.selectable) { |
There was a problem hiding this comment.
This section is only a small code readability improvement.
marzecdawid
force-pushed
the
better-cursor-behaviour-in-tree-with-ctrl
branch
from
aa5d550
to
9217be2
Compare
KoBeWi
reviewed
Jun 21, 2023
KoBeWi
approved these changes
Jun 21, 2023
marzecdawid
force-pushed
the
better-cursor-behaviour-in-tree-with-ctrl
branch
from
9217be2
to
9abbdea
Compare
YuriSizov
added
the
cherrypick:4.1
akien-mga
changed the title
|
Thanks! |
|
Cherry-picked for 4.1.1. |
YuriSizov
removed
the
cherrypick:4.1
|
I believe I have found a regression possibly caused by this PR. 2023-09-20.17-53-21.mp4 |
lufog
reviewed
Sep 20, 2023
Comment on lines
+4410
to
+4411
| selected_item = p_item; | ||
| selected_col = p_column; |
There was a problem hiding this comment.
If change this to:
selected_item = nullptr;
selected_col = -1;This will fix the problem, but the frame of the deselected element
will break.
|
Please open a new issue. |
|
Done #81988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes cursor behaviour for selecting multiple items in
Treewhile holding CTRL button.Before:
2023-01-07.13-43-32.mp4
After:
2023-01-07.13-45-51.mp4
The fix in
scene/gui/tree.cppexposed a problem ineditor/scene_tree_editor.cppas every node in the list was selected/deselected each time there was any selection change:2023-01-07.14-00-48.mp4
So in
editor/scene_tree_editor.cppI fixed it to behave the same as before:2023-01-07.14-05-38.mp4
I think the
_update_selectioninscene_tree_editor.cppshould be redesigned to be more dependent on the selection from a Tree, not the opposite way. Or Space button shouldn't be for rename where there is F2 for that, but it is a topic for separete proposal :)