Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toggling pause / stop button to AnimationPlayerEditor #71321

Merged
merged 1 commit into from Jan 13, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 13, 2023

This PR depends on #33733, recommended that we merge #33733 first.

Make the button for stopping the AnimationPlayerEditor to be the Pause button during playback and the Stop button otherwise (while pausing), to clarify operation of resetting the animation position.

Godot.2023.01.13.-.20.35.58.01.mp4

@TokageItLab TokageItLab added this to the 4.0 milestone Jan 13, 2023
@TokageItLab TokageItLab requested a review from a team January 13, 2023 11:47
@TokageItLab TokageItLab requested a review from a team as a code owner January 13, 2023 11:47
@TokageItLab TokageItLab force-pushed the stop-edit branch 2 times, most recently from 8f5e447 to 54d0f86 Compare January 13, 2023 17:20
@TokageItLab TokageItLab added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 13, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:animation topic:editor usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants