Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Improve usability of setter chains #72398

Merged
merged 1 commit into from Feb 2, 2023
Merged

GDScript: Improve usability of setter chains #72398

merged 1 commit into from Feb 2, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Jan 30, 2023

  • Consider PackedArrays non-shared since they are copied on C++/script boundaries.
  • Add error messages in the analyzer when assigning to read-only properties.
  • Add specific error message at runtime when assignment fails because the property is read-only.

Fix #62857

@vnen vnen added this to the 4.0 milestone Jan 30, 2023
@vnen vnen requested review from a team as code owners January 30, 2023 17:55
@akien-mga
Copy link
Member 

modules/gdscript/tests/gdscript_test_runner.cpp:209: ERROR: CHECK( result.passed ) is NOT correct!
  values: CHECK( false )
  logged: /Users/runner/work/godot/godot/modules/gdscript/tests/scripts/analyzer/errors/assign_to_read_only_property_indirectly.gd
          GDTEST_ANALYZER_ERROR
Cannot call non-static function "body_get_direct_state()" on the class "PhysicsServer3D" directly. Make an instance instead.

@akien-mga
Copy link
Member

Leak sanitizer doesn't seem to be happy.

@vnen
GDScript: Improve usability of setter chains
5fc7918 
- Consider PackedArrays non-shared since they are copied on C++/script
  boundaries.
- Add error messages in the analyzer when assigning to read-only
  properties.
- Add specific error message at runtime when assignment fails because
  the property is read-only.
@vnen
Copy link
Member Author

vnen commented Feb 2, 2023

Fixed the leak.

@akien-mga akien-mga merged commit a43ec33 into godotengine:master Feb 2, 2023
@akien-mga
Copy link
Member

Thanks!

@vnen vnen deleted the gdscript-setter-chain branch February 2, 2023 16:07
This was referenced Feb 16, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Can't directly modify points of Line2D
2 participants
@vnen @akien-mga