Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to override EditorExportPlugin::_export_end() in C++ #72572

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Feb 2, 2023

I working on a custom godot engine which needing a custom exporter plugin in cpp.
However, unlike EditorExportPlugin::_export_file() and EditorExportPlugin::_export_begin(), EditorExportPlugin::_export_end() is private and can't be overrided to implement my logic directly in cpp.

I don't know this is intended or not, but in GDScript, these 3 methods can be override directly.
So I do a little change to let EditorExportPlugin::_export_end() can be overrided in cpp.

@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/override_export_end_in_Cpp branch from 70b203e to 5afc311 Compare April 22, 2023 05:34
@YuriSizov YuriSizov requested a review from a team June 20, 2023 12:29
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 20, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@akien-mga akien-mga modified the milestones: 4.3, 4.x Nov 1, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping for reduz to review as he designed this, but this didn't happen.

The changes seem sensible to me and consistent with how _export_begin is implemented, so this should be fine.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Nov 1, 2023
@akien-mga akien-mga changed the title Provide ability to override _export_end() in cpp. Provide ability to override EditorExportPlugin::_export_end() in C++ Jan 4, 2024
@akien-mga akien-mga merged commit 38a1e17 into godotengine:master Jan 4, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants