Add more useful Visual Shader nodes

[paddy-exe]

Part of godotengine/godot-proposals#5106

• RotationByAxis node
  

Talked about with @QbieShay:

• World Position from Depth (depth texture)
  

• Screen Normal in World Space
  

[Chaosus]

RotationByAxis node

Isn't it the same as VisualShaderNodeParticleMultiplyByAxisAngle?

[paddy-exe]

Isn't it the same as VisualShaderNodeParticleMultiplyByAxisAngle?

Not sure to be honest. This node was part of a proposal by @QbieShay for Spatial Shaders (I think).

[QbieShay]

Yes this is for spatial shaders!

[paddy-exe]

Fixed the depth-ndc for GLES3 just like in #65160

[YuriSizov]

You need to update the generated documentation, we're in the 4.1 stretch now 😎

[QbieShay]

Hey, i tried to use the rotation by axis thigng but it didnt work out

[paddy-exe]

I rebased my changes on top and my example still works here:

Doesn't seem to change when I use your Node setup (still works):

Also @QbieShay:
Are you happy with the changes (see my last commit and comment)?
Additionally, should I add the option to input the angle both in radian as well as degrees or only in radians?

[QbieShay]

I think perhaps it could be a tickbox on the node instead? I think having 2 inputs would be confusing. And perhaps by default it could use CUSTOM.x if no value is supplied?

[paddy-exe]

I think perhaps it could be a tickbox on the node instead? I think having 2 inputs would be confusing.

Wouldn't an options drow-down be better than a tick box UX-wise?

And perhaps by default it could use CUSTOM.x if no value is supplied?

I think this could get very confusing for a lot of users as it's not shown in the UI what the default value is. So I would be personally against implementing this. It could be still added later but doing it the other way around would break compatability I assume.

[QbieShay]

I would imagine that rotating particles would be the most basic case but actually probably not, you're right. And you're right about the option drop down too ^^ although maybe it can just be radians. If everything is already in radians we don't need to support degrees. Maybe in the future a float param that auto-converts degrees would be better?

[paddy-exe]

And you're right about the option drop down too ^^ although maybe it can just be radians. If everything is already in radians we don't need to support degrees. Maybe in the future a float param that auto-converts degrees would be better?

Yes, IIRC everything is handled as radians. I do find degrees better to use but that can be discussed in a proposal some other time.

So all in all, everything should be finished then, right? Can this be merged?

[QbieShay]

Yep. Thank you for this work.

[YuriSizov]

Could you squash commits and amend the commit message?

[paddy-exe]

Could you squash commits and amend the commit message?

Squashed and rebased :)

Edit: I think the broken CI is because of a compatability break not connected to this PR

[YuriSizov]

No, it's just a "normal" issue because "No space left on device".

PS. You didn't amend the commit message, btw 🙃

[paddy-exe]

No, it's just a "normal" issue because "No space left on device".

What do you mean by "no space left on device"? Is that a GitHub CI error still?

PS. You didn't amend the commit message, btw 🙃

Ah damn... my bad :/ I usa a visual git editor and thought I used the correct command... Is there something specific I need to add? I reworked it now to tell the changes in bullet points

[YuriSizov]

What do you mean by "no space left on device"? Is that a GitHub CI error still?

Yes, it's an issue with CI itself, not with our project or your PR.

Is there something specific I need to add?

No, it just doesn't follow the commit message style preferred by the project.

[YuriSizov]

Thanks, great work!