Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DEPTH to the visual shader output (for spatial mode) #73691

Merged
merged 1 commit into from Jul 12, 2023
Merged

Add DEPTH to the visual shader output (for spatial mode) #73691

merged 1 commit into from Jul 12, 2023

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Feb 21, 2023

Adds a new port:
image

@Chaosus Chaosus requested a review from a team as a code owner February 21, 2023 17:23
@clayjohn clayjohn added this to the 4.1 milestone Feb 21, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
QbieShay
QbieShay approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I haven't been able to make a depth writing shader in a long time (i forgot how to).

Exposing it is good, if there's bugs people will report them and we'll look into them ^^

@YuriSizov YuriSizov merged commit 53d0e6c into godotengine:master Jul 12, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Chaosus Chaosus deleted the vs_depth branch July 14, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QbieShay QbieShay QbieShay approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chaosus @YuriSizov @QbieShay @clayjohn