Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate shortcut events to SubViewports #76926

Merged
merged 1 commit into from May 11, 2023

Conversation

Sauermann
Copy link
Contributor

Followup to #62378 and #57894 in order to remove uses of push_unhandled_input, because that function no longer propagates events to SubViewports.

`push_unhandled_input` no longer propagates events to `SubViewports`.
@akien-mga akien-mga added this to the 4.1 milestone May 11, 2023
@akien-mga akien-mga merged commit f717cc0 into godotengine:master May 11, 2023
@Sauermann Sauermann deleted the fix-call-to-unhandled-input branch May 11, 2023 09:49
@akien-mga
Copy link
Member

Thanks!

@trollodel
Copy link
Contributor

push_unhandled_input, because that function no longer propagates events to SubViewports.

It would be nice to document this behavior in push_event and push_unhandled_input as it's not obvious IMO.
Anyway, thanks for the fix.

@Sauermann
Copy link
Contributor Author

Sauermann commented May 12, 2023

@trollodel I will do that soon. Already have a PR nearly ready for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants