Fixed width of CapsuleShape2D::get_rect + set center to center of shape #77065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
reviewed
May 14, 2023
The width of the rect was only half of the width of the shape, and the 0;0 coord was at the top left of the rect. Now the width properly matches the width of the shape, and the 0;0 coord is at the center of the shape. It should match the behavior of Godot 3.X.
FranckRJ
force-pushed
the
fix-capsuleshape2d-getrect
branch
from
e21b2e0
to
ab5462e
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
|
Fixed it, thanks for notifying me. I started using godot last week and it seems to be a really great product, I hope I'll be able to contribute more in the future! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width of the rect was only half of the width of the shape, and the 0;0 coord was at the top left of the rect.
Now the width properly matches the width of the shape, and the 0;0 coord is at the center of the shape. It should match the behavior of Godot 3.X (https://github.com/godotengine/godot/blob/3.x/scene/resources/capsule_shape_2d.cpp#L93-L99).
I haven't found a test file for CapsuleShape2D, I don't know if I have to create one or if it should be written in an existing file, or something else.