Fix crash when using tile atlas merge with recreated alt tile #77382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please amend the commit message to make it a meaningful description of what it does (e.g. the same as the PR title which seems fine). |
rakkarage
force-pushed
the
tileset_merge_crash
branch
from
4cd9068
to
88d2ed4
Compare
groud
approved these changes
May 26, 2023
|
Thanks! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If u delete an alt tile and re-add it it gets a new id.
Merging calls
create_alternative_tilefor each tile that recycles old unused ids / packs ids.Was crashing when trying to get data from an alt tile that did not exist anymore.
Closes: #77381