Consider all triangles for retention in Delaunay Triangulation #78368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
approved these changes
Jun 17, 2023
There was a problem hiding this comment.
The change is correct. I've somehow overlooked this incorrect condition previously (#75805 (comment), #75805 (comment)).
MewPurPur
approved these changes
Jun 17, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change in the Delaunay Triangulation code introduced a bug where the last potential triangle would automatically be disregarded, even if it was valid. This pull request fixes the loop condition to ensure that all triangles are properly considered and potentially kept.