Get rid of some compilation warnings. #7851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojidar-bg
reviewed
Feb 20, 2017
modules/gdscript/gd_editor.cpp
Outdated
| @@ -2645,6 +2645,8 @@ Error GDScriptLanguage::lookup_code(const String& p_code, const String& p_symbol | |||
|
|
|||
| switch(p.get_completion_type()) { | |||
|
|
|||
| case GDParser::COMPLETION_GET_NODE: { | |||
| } break; | |||
| case GDParser::COMPLETION_NONE: { | |||
There was a problem hiding this comment.
You can do better here with:
case GDParser::COMPLETION_GET_NODE:
case GDParser::COMPLETION_NONE: {
} break;
bojidar-bg
reviewed
Feb 20, 2017
main/tests/test_gdscript.cpp
Outdated
| @@ -318,6 +318,7 @@ static void _parser_show_block(const GDParser::BlockNode *p_block,int p_indent) | |||
| else | |||
| _print_indent(p_indent,"return "); | |||
| } break; | |||
| case GDParser::ControlFlowNode::CF_MATCH: break; | |||
There was a problem hiding this comment.
That one is wrong, it should "unparse" the match statement, instead of just covering the issue in a break. If you think it would be too complex for the scope of this PR, you should either leave a TODO comment, or not change it at all.
|
Hi @shlomif, nice to see a fellow Mageia dev here ;) |
|
Thanks for the commentary @bojidar-bg ! I'll try to tend to it soon. |
Redone the commit based on the input in godotengine#7851 . Not all warnings were fixed but it's a start.
shlomif
force-pushed
the
fix-some-compilation-warnings
branch
from
af83f10
to
0a2c387
Compare
|
OK , I redid the commit per @bojidar-bg 's comments. |
akien-mga
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear by default on Mageia Linux v6. Not all compilation warnings
were fixed but it's a start.