Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve string drawing in the tiledata editor #78522

Merged
merged 1 commit into from Jul 7, 2023
Merged

Improve string drawing in the tiledata editor #78522

merged 1 commit into from Jul 7, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Jun 21, 2023 •
edited

This PR makes 3 improvements to tiledata strings:

  • Bump them up a little so they are vertically right in the middle, not a little under. (solution might not be ideal, but seems to look fine for our default font)
  • Thicken the outline. Size 1 is so small it's practically useless for discerning numbers on all backgrounds, should be at least 3.
  • Handle all variant types gracefully.

AABB example:

image

Vector3i example:

image

String example:

image

@akien-mga akien-mga added this to the 4.2 milestone Jun 21, 2023
@akien-mga akien-mga requested review from KoBeWi and groud June 21, 2023 14:55
@MewPurPur MewPurPur changed the title Improve string printing in the tiledata editor Improve string drawing in the tiledata editor Jun 21, 2023
@YuriSizov YuriSizov added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 7, 2023
@akien-mga akien-mga merged commit 81c6694 into godotengine:master Jul 7, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the improve-tileset-labels branch July 7, 2023 15:01
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud approved these changes

@KoBeWi KoBeWi Awaiting requested review from KoBeWi

Assignees
No one assigned
Labels
enhancement topic:editor topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MewPurPur @akien-mga @YuriSizov @groud