Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reimporting files with non lowercase name extension #78567

Merged
merged 1 commit into from Jul 12, 2023

Conversation

NiskashY
Copy link
Contributor

@NiskashY NiskashY commented Jun 22, 2023

Fix #78535.

Tested locally - files with the extensions .fbx .FBX .fBx work the same

@akien-mga akien-mga changed the title [FIX] reimporting fbx file formats Fix reimporting FBX files with non lowercase extension Jun 22, 2023
@AThousandShips AThousandShips requested a review from a team June 22, 2023 15:20
@fire
Copy link
Member

fire commented Jun 22, 2023

Design pass 👍 .

@YuriSizov
Copy link
Contributor

Could you please amend your commit message? Title of this PR right now is a good option to use.

@akien-mga
Copy link
Member

Actually the change in this PR isn't specific to FBX, so it would be better to describe what this PR changes, more than one of the symptoms of the bug it fixes.

@NiskashY NiskashY changed the title Fix reimporting FBX files with non lowercase extension Fix reimporting files with non lowercase name extension Jul 8, 2023
@YuriSizov
Copy link
Contributor

You didn't actually amend the commit message, only the title of this PR. I amended it for you.

@YuriSizov YuriSizov merged commit 7aff59f into godotengine:master Jul 12, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non lowercase extension triggers silent error when importing FBX files
5 participants