Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid minimum size for translated messages in option button #78752

Closed
wants to merge 1 commit into from

Conversation

Dragoncraft89
Copy link
Contributor

computing the minimum size was done on the untranslated messages. However, when auto translation is enabled these will most likely not match their translated counterparts which leads to layout bugs

@Dragoncraft89 Dragoncraft89 requested a review from a team as a code owner June 27, 2023 14:27
@KoBeWi KoBeWi added this to the 4.2 milestone Jun 27, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Jun 28, 2023

Makes sense, but the text should probably be cached, to avoid translating it often when not necessary. Check PopupMenu, its Item subclass has xl_text property. OptionButton could get something like that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants