Fix invalid shader compilation when using hint_normal_roughness_texture in mobile backend
#78839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and not using the Forward+ backend
AThousandShips
added
bug
topic:rendering
topic:shaders
and removed
topic:rendering
labels
clayjohn
approved these changes
Jun 29, 2023
akien-mga
added
the
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78411
Returns shader parse error when using
hint_normal_roughness_textureand not using the Forward+ backend.Previously this error was returned only when using the GL compatibility renderer, but the hint is also unsupported on the mobile backend, and using it allowed shader compilation to continue and consequently generate invalid shader code.