Change property hint range for camera attributes exposure multiplier #79138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.1
clayjohn
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
The range was intended to fit well when using physical light units. But since this variable is exposed even when physical light units are disabled, it makes sense to use a reduced range by default with the ability to go outside the range.
To be clear, the range is not absurd, it is perfectly appropriate when dealing with real light units.
|
Thanks! |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current range hint max of 2048 is
just absurdtoo high. In the default scene, an exposure multiplier of about 50 blows up to a completely white screen. I was watching somebody try out Godot 4.1 on a Discord stream when they changed this value and were surprised that most of the slider was completely useless.This PR changes the range hint to have a max of 8, but also adds
or_greaterso any value can still be typed in.