Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix recursion level check for array stringification #79370

Merged
merged 1 commit into from Aug 18, 2023
Merged

Core: Fix recursion level check for array stringification #79370

merged 1 commit into from Aug 18, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added bug topic:core crash regression cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 12, 2023
@dalexeev dalexeev added this to the 4.2 milestone Jul 12, 2023
@dalexeev dalexeev requested a review from a team as a code owner July 12, 2023 12:04
@dalexeev dalexeev added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 labels Jul 12, 2023
@akien-mga akien-mga added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release and removed cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 18, 2023
@akien-mga akien-mga merged commit 1d70968 into godotengine:master Aug 18, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the core-array-recursion-check branch August 18, 2023 15:26
@dalexeev dalexeev mentioned this pull request Aug 25, 2023
Closed
@akien-mga
Copy link
Member

Doesn't cherry-pick easily to 3.x, could use a dedicated PR.

@dalexeev dalexeev removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 29, 2023
@dalexeev
Copy link
Member Author

In 3.x, printing a recursive array does not crash, this has been fixed by #28217 (using a stack instead of recursion_count). However, var2str still crashes. This is a VariantWriter bug, not Variant::stringify().

var a = []
a.append(a)
print(var2str(a))

@dalexeev dalexeev mentioned this pull request Aug 29, 2023
Merged
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash regression topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Crash when printing array that contains itself
3 participants
@dalexeev @akien-mga @YuriSizov