Fix completion option location not found #80283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly I don't recall, but I guess this change makes sense? A script does not require class_name to be present. |
akien-mga
added
the
cherrypick:4.1
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80280
I'm not 100% sure about myself but I feel it didn't make sense to use class_name while we are looking to see if the property is inside the class.So I treated it just as simply a confusion but maybe there was another case that needed this if so we would need to find a solution to accommodates both situation.
I think it was @EricEzaM who made this part of the code so he might have a better understanding of wether this was simply a mistake or if there was a specific case this was targeting.