Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Fix exporting for Android #80521

Merged
merged 1 commit into from Aug 14, 2023
Merged

C#: Fix exporting for Android #80521

merged 1 commit into from Aug 14, 2023

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented Aug 11, 2023

You should now be able to compile the C# Android export template properly and export C# Android within the editor.
Only tested the Android export for a small project and it's not clear if this causes any other issues.
image
image
image

@raulsntos
Copy link
Member

raulsntos commented Aug 12, 2023

Hey 👋 Thanks for contributing to the .NET module.

Since this is your first time contributing, make sure you've read CONTRIBUTING.md. You'll have to squash all the commits into one, take a look at the PR workflow documentation for more information. Also, feel free to reach out on Rocket Chat if you need help.

@scgm0
Copy link
Contributor Author

scgm0 commented Aug 12, 2023

Hey wave Thanks for contributing to the .NET module.嘿 wave 感谢您对 .NET 模块的贡献。

Since this is your first time contributing, make sure you've read CONTRIBUTING.md. You'll have to squash all the commits into one, take a look at the PR workflow documentation for more information. Also, feel free to reach out on Rocket Chat if you need help.由于这是您第一次贡献,请确保您已阅读 CONTRIBUTING.md。您必须将所有提交压缩为一个,请查看 PR 工作流程文档以获取更多信息。另外,如果您需要帮助,请随时通过 Rocket Chat 联系。

Hey wave Thanks for contributing to the .NET module.嘿 wave 感谢您对 .NET 模块的贡献。

Since this is your first time contributing, make sure you've read CONTRIBUTING.md. You'll have to squash all the commits into one, take a look at the PR workflow documentation for more information. Also, feel free to reach out on Rocket Chat if you need help.由于这是您第一次贡献,请确保您已阅读 CONTRIBUTING.md。您必须将所有提交压缩为一个,请查看 PR 工作流程文档以获取更多信息。另外,如果您需要帮助,请随时通过 Rocket Chat 联系。

Hey wave Thanks for contributing to the .NET module.

Since this is your first time contributing, make sure you've read CONTRIBUTING.md. You'll have to squash all the commits into one, take a look at the PR workflow documentation for more information. Also, feel free to reach out on Rocket Chat if you need help.

Thanks, any more questions now?

@scgm0 scgm0 requested a review from raulsntos August 12, 2023 12:14
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@akien-mga akien-mga merged commit 8a9e04b into godotengine:master Aug 14, 2023
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Aug 14, 2023

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants