Exit early in TextEdit::_get_column_pos_of_word to improve highlight performance
#80809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Aug 20, 2023
match words, just early break the while loop. This will improve a lot when p_search.length is way too long since p_from_column will only plus 1 every loop
jsjtxietian
force-pushed
the
early-quit-in-_get_column_pos_of_word
branch
from
40166c2
to
70dad7e
Compare
AThousandShips
changed the title
TextEdit::_get_column_pos_of_word to improve hightlight performace
akien-mga
changed the title
TextEdit::_get_column_pos_of_word to improve hightlight performaceTextEdit::_get_column_pos_of_word to improve highlight performace
akien-mga
approved these changes
Aug 21, 2023
|
Thanks! |
akien-mga
changed the title
TextEdit::_get_column_pos_of_word to improve highlight performaceTextEdit::_get_column_pos_of_word to improve highlight performace
akien-mga
changed the title
TextEdit::_get_column_pos_of_word to improve highlight performaceTextEdit::_get_column_pos_of_word to improve highlight performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #80801
If in the while loop inside
_get_column_pos_of_word,string.findorfindncan't find any match words, we can just early break the while loop to imporove cpu performance.In the origin logic without early break,
p_from_columnwill only plus 1 every loop, this means basically this function will do thestring.findorfindnforp_search.lengthtimes, this is way too slow for a longp_searchstring.