Fix JavaScriptBridge.eval() never returning PackedByteArray

[OverloadedOrama]

JavaScriptBridge.eval() currently returns 20 on array buffers, which used to be the enumerator value of Godot 3.x's TYPE_POOL_BYTE_ARRAY (and now is the value of TYPE_COLOR in 4.x), while it should return 29 which is the enumerator value of TYPE_PACKED_BYTE_ARRAY.

The rest of the enumerator values of the file seem OK, but feel free to let me know if you see anything else that needs to be updated.

[AThousandShips]

LGTM, can't test for web but the update of type should be correct

[adamscott]

Seems fine to me. Without this PR, it returns a Variant::Color type that will fail to map here:

godot/platform/web/javascript_bridge_singleton.cpp

Lines 332 to 355 in 6da4ad1

	Variant JavaScriptBridge::eval(const String &p_code, bool p_use_global_exec_context) {
	union js_eval_ret js_data;
	PackedByteArray arr;
	VectorWriteProxy<uint8_t> arr_write;
	Variant::Type return_type = static_cast<Variant::Type>(godot_js_eval(p_code.utf8().get_data(), p_use_global_exec_context, &js_data, &arr, &arr_write, resize_PackedByteArray_and_open_write));
	switch (return_type) {
	case Variant::BOOL:
	return js_data.b;
	case Variant::FLOAT:
	return js_data.d;
	case Variant::STRING: {
	String str = String::utf8(js_data.s);
	free(js_data.s); // Must free the string allocated in JS.
	return str;
	}
	case Variant::PACKED_BYTE_ARRAY:
	arr_write = VectorWriteProxy<uint8_t>();
	return arr;
	default:
	return Variant();
	}
	}

[adamscott]

@OverloadedOrama Can you remove this part from your commit message?

The rest of the enumerator values of the file seem OK, but feel free to let me know if you see anything else that needs to be updated.

[OverloadedOrama]

Yup, should be removed now.

[AThousandShips]

I'd remove the reference to the docs as well as that link isn't permanent, alternatively rename it to 4.1 instead of stable

[OverloadedOrama]

I renamed it to 4.1.

[akien-mga]

I reviewed the file and confirmed that the other hardcoded type values are correct. There were a couple outdated comments (REAL -> FLOAT) so I pushed an update to change those too.

Also wrapped the commit message to <= 78 chars and simplified a bit, it was quite verbose for such a small change :)

[akien-mga]

Thanks!

[YuriSizov]

Cherry-picked for 4.1.2.