Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent creating any type of file with a leading dot #81075

Merged
merged 1 commit into from Sep 8, 2023
Merged

Prevent creating any type of file with a leading dot #81075

merged 1 commit into from Sep 8, 2023

Conversation

SekoiaTree
Copy link
Contributor

@SekoiaTree SekoiaTree commented Aug 28, 2023 •
edited

Fixes #62497, ports #62940 to master. Tested with every filesystem dock option, as well as saving resources and scenes from other docks.

Co-authored-by: gotnospirit gotnospirit@gmail.com

@SekoiaTree SekoiaTree requested a review from a team as a code owner August 28, 2023 13:31
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 28, 2023
@AThousandShips
Copy link
Member

Since this is a port I'd say adding the original author as co-author is appropriate

@SekoiaTree
Copy link
Contributor Author

Sure! How do I do that?

@AThousandShips
Copy link
Member

Add

Co-authored-by: Name <Email>

Get the details from the original PR commit

AThousandShips
AThousandShips reviewed Aug 28, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
editor/scene_create_dialog.cpp Outdated Show resolved Hide resolved
@SekoiaTree SekoiaTree force-pushed the prevent-leading-dot branch 3 times, most recently from 226f146 to 703d9c6 Compare August 28, 2023 16:19
@AThousandShips
Copy link
Member

Please squash your commits into one, see here

And also add the co-author

@SekoiaTree
Copy link
Contributor Author

@gotnospirit I need your email to add you as coauthor, but I can't find it anywhere :/

@SekoiaTree
Copy link
Contributor Author

SekoiaTree commented Aug 28, 2023 •
edited

Squashed commits. For co-author, I can't find the email anywhere. There's a noreply address from github somewhere, but idk what it is either.

Edit: of course, I immediately find it. nevermind about the address, then.

@KoBeWi
Copy link
Member

KoBeWi commented Aug 28, 2023

You can get the author's email from commit's patch
https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/62940.patch

@SekoiaTree
Copy link
Contributor Author

Yep, found that immediately after... Sorry!

@YuriSizov YuriSizov added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 30, 2023
@SekoiaTree SekoiaTree force-pushed the prevent-leading-dot branch 2 times, most recently from 888f1a4 to 9909adc Compare September 7, 2023 15:15
@SekoiaTree @AThousandShips @gotnospirit
Prevent creating any type of file with a leading dot
bbeb2f9 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: gotnospirit <gotnospirit@gmail.com>
@akien-mga akien-mga merged commit 119f379 into godotengine:master Sep 8, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@SekoiaTree SekoiaTree deleted the prevent-leading-dot branch September 8, 2023 19:27
@akien-mga akien-mga mentioned this pull request Sep 18, 2023
Merged
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Can't be cherry-picked, unfortunately, as it depends on #78744. Can likely be redone for 4.1, but it's not extremely important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
5 participants
@SekoiaTree @AThousandShips @KoBeWi @akien-mga @YuriSizov